fix: remove inline jsr: import from generated functions template
#4591
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate the template generated by 'supabase functions new' produces deno lint errors on line 6 due to inline jsr: import without version specifier: import jsr:@supabase/functions-js/edge-runtime.d.ts this triggers two default deno lint rules: - no-import-prefix: inline jsr: dependency not allowed - no-unversioned-import: missing version in specifier fix moves the dependency declaration to deno.json with proper versioning and updates index.ts to use bare specifier import as recommended by deno. closes supabase#4424
sweatybridge
reviewed
Dec 8, 2025
| // This enables autocomplete, go to definition, etc. | ||
|
|
||
| // Setup type definitions for built-in Supabase Runtime APIs | ||
| import "jsr:@supabase/functions-js/edge-runtime.d.ts" |
Contributor
There was a problem hiding this comment.
@nyannyacha is this a problem we need to address?
Contributor
There was a problem hiding this comment.
The mentioned lints appear to have been introduced in Deno v2.5.
Since we're currently fixed at Deno 2.1.4, not fixing the lints wouldn't cause much impact. However, the problem is that we can't prevent users from using the latest version of Deno.
So in my opinion... yes, I agree to change the template style so the lints don't complain.
|
Thanks, for that, it works for me |
7ttp
changed the title
jsr: import from generated functions template
|
+1 thanks @sweatybridge @7ttp |
sweatybridge
approved these changes
Jan 30, 2026
sweatybridge
changed the title
jsr: import from generated functions templatejsr: import from generated functions template
Pull Request Test Coverage Report for Build 21512140722Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The template generated by
supabase functions newproduces code that triggers Deno lint errors due to an inlinejsr:import without a version specifier.Problem
The generated template includes:
This violates two default Deno lint rules:
jsr:dependencies are not allowedRelated
supabase functions newgenerates code with Deno IDE and linting errors #4424