Skip to content

Conversation

@emir-karabeg
Copy link
Collaborator

@emir-karabeg emir-karabeg commented Jan 30, 2026

Summary

Hides the icon for note blocks in the workflow preview to match the visual representation of note blocks on the canvas. This ensures consistency across the UI.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Other: ___________

Testing

The change was verified by running lint and type checks. Manually confirmed that note blocks in the preview no longer display an icon.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos


Open in Cursor Open in Web

Co-authored-by: emir <emir@simstudio.ai>
@cursor
Copy link

cursor bot commented Jan 30, 2026

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@vercel
Copy link

vercel bot commented Jan 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Jan 30, 2026 3:33am

Request Review

@emir-karabeg emir-karabeg changed the title Note block preview icon improvement(note): icon in preview Jan 30, 2026
@waleedlatif1 waleedlatif1 marked this pull request as ready for review January 30, 2026 04:41
@waleedlatif1
Copy link
Collaborator

@cursor review

@waleedlatif1
Copy link
Collaborator

@greptile

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 30, 2026

Greptile Overview

Greptile Summary

Conditionally hides the icon in note block headers within the workflow preview component to match how note blocks appear on the canvas (where they only show the title without an icon).

Confidence Score: 5/5

  • This PR is safe to merge with no risks
  • The change is minimal, well-contained, and correctly implements the visual consistency fix by conditionally rendering the icon based on block type
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/components/preview/components/preview-workflow/components/block/block.tsx Conditionally hides icon for note blocks in preview to match canvas representation

Sequence Diagram

sequenceDiagram
    participant User
    participant PreviewWorkflow
    participant PreviewBlock
    participant BlockConfig
    
    User->>PreviewWorkflow: View workflow preview
    PreviewWorkflow->>PreviewBlock: Render block with data
    PreviewBlock->>BlockConfig: getBlock(type)
    BlockConfig-->>PreviewBlock: Return block config with icon
    
    alt Block type is 'note'
        PreviewBlock->>PreviewBlock: Set isNoteBlock = true
        PreviewBlock->>PreviewBlock: Skip icon rendering
        PreviewBlock-->>User: Display note block (title only)
    else Block type is not 'note'
        PreviewBlock->>PreviewBlock: Set isNoteBlock = false
        PreviewBlock->>PreviewBlock: Render icon with title
        PreviewBlock-->>User: Display block (icon + title)
    end
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants