Update Color enum in overloads_evaluation.py to have >1 member
#2165
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enum looks like it has two members, but it actually has only one, because `Color.RED` and `Color.BLUE` have the same value; `Color.BLUE` here is actually just an alias for `Color.RED`: ```pycon >>> from enum import Enum >>> class Color(Enum): ... RED = 1 ... BLUE = 1 ... >>> list(Color) [<Color.RED: 1>] >>> Color.RED is Color.BLUE True ``` ty is able to understand that, and this leads to ty failing the assertion a few lines below: https://github.com/python/typing/blob/b40321ce2037f67e1976e1b03a7766636ae54dc7/conformance/tests/overloads_evaluation.py#L160-L162 because it is able to infer that the second overload will never be taken, and therefore infers the more precise type of `Literal[0]` as a result of the `expand_enum()` call. I don't think that's what the assertion was trying to test, so this PR updates the enum to have >1 member.
AlexWaygood
added
the
topic: conformance tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enum looks like it has two members, but it actually has only one, because
Color.REDandColor.BLUEhave the same value;Color.BLUEhere is actually just an alias forColor.RED:ty is able to understand that, and this leads to ty failing the assertion a few lines below:
typing/conformance/tests/overloads_evaluation.py
Lines 160 to 162 in b40321c
because it is able to infer that the second overload will never be taken, and therefore infers the more precise type of
Literal[0]as a result of theexpand_enum()call.I don't think that's what the assertion was trying to test, so this PR updates the enum to have >1 member.