gh-144261: SyntaxWarning when await an unawaitable constant #144271
Conversation
Locked-chess-official
requested review from
iritkatriel and
markshannon
as code owners
|
I will check which cause the SyntaxWarning to SyntaxError. This is on my computer: 
|
| check_awaitable(compiler* c, expr_ty e) | ||
| { | ||
| /* Emit a warning when awaiting obvious non-awaitable literal objects. */ | ||
| switch (e->kind) { |
There was a problem hiding this comment.
It's better to swap the kinds and only consider kinds that are awaitable. Otherwise, we need to update that list whenever we add a new kind that is not awaitable.
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
This requires a What's New entry, and tests as well.
| @@ -0,0 +1 @@ | |||
| SyntaxWarning when await an unawaitable constant. | |||
There was a problem hiding this comment.
This requires better phrasing. This does not explain anything.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Since the PR is not ready I'm going to put it as a draft for now. |
|
I take a day but fail to find what upgrade "SyntaxWarning" to "SyntaxError". |
2 participants
Uh oh!
There was an error while loading. Please reload this page.