Skip to content

Conversation

@vadimi
Copy link

@vadimi vadimi commented Jan 22, 2026

This PR is based on #8434, but as stated in comments there are breaking changes in echo/v5 and it also requires go 1.25, so creating go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/v5/otelecho to make sure echo/v4 instrumentation still works.

echo v5 has breaking changes, so introducing github.com/labstack/echo/v5/otelecho to avoid breaking the existing otelecho
@vadimi vadimi requested a review from a team as a code owner January 22, 2026 22:46
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 22, 2026

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: vadimi / name: Vadim (4ff292b)

@flc1125
Copy link
Member

flc1125 commented Jan 23, 2026

Thank you for your contribution. It is a duplicate of #8434. Considering the principle of priority, we will use the other PR as the baseline, unless no one follows up on that one.

@flc1125 flc1125 added the duplicate This issue or pull request already exists label Jan 23, 2026
@dmathieu
Copy link
Member

As this PR does it "the right way" (with a new component) contrarily to the other one, I'd be tempted to take this one as canonical.

This brings the question of new components.
Why should this new component be in this repo? Could it be in a repo owned by echo?
Will you be listed as a codeowner for this repository (with all that entitles, as documented in the contributing document)?

@arielsrv arielsrv mentioned this pull request Jan 23, 2026
@flc1125 flc1125 removed the duplicate This issue or pull request already exists label Jan 23, 2026
@vadimi
Copy link
Author

vadimi commented Jan 23, 2026

Why should this new component be in this repo? Could it be in a repo owned by echo?

I've asked echo maintainer if it would makes sense to add the new otel package to one of the echo repos (labstack/echo-contrib#135)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants