snakemake/remote_files: Add minimum version check for Snakemake #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `min_version` in the shared `remote_files.smk` so that individual workflows that import it don't have to remember to add the version check. Based on feedback from @victorlin in mpox <nextstrain/mpox#339 (comment)>
3 tasks
victorlin
approved these changes
Sep 30, 2025
Member
victorlin
left a comment
victorlin
left a comment
There was a problem hiding this comment.
Thanks for considering! This is a small suggestion but also a new way of doing things in nextstrain/shared, so I'm curious what others think.
I think it's analogous to something like Augur's pandas version constraints, which are declared in package metadata and checked by pip/conda at install time. Since nextstrain/shared is installed by simply copying the contents of the repo with no checks, the only way to check dependency versions is at run time such as in this PR.
In addition to this, individual phylogenetic workflows can still declare and check their own minimum Snakemake versions in Snakefile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Add
min_versionin the sharedremote_files.smkso that individual workflows that import it don't have to remember to add the version check.Based on feedback from @victorlin in mpox
nextstrain/mpox#339 (comment)
Checklist