-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Added PyPIPublisherV0 to make-options to allow for Courtesy Push Builds #21721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| "PublishTestResultsV2", | ||
| "PublishToAzureServiceBusV1", | ||
| "PublishToAzureServiceBusV2", | ||
| "PyPIPublisherV0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a deprecated task, or a new task that was introduced recently? Why wasn’t it already available in the Make options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecating CondaEnvironmentV0, PyPIPublisherV0 tasks
This task is being deprecated in S268 in the above PR
However, our courtesy push build did not pick this up due to the task not being available in the make-options.json
The filter-task.js is only picking up / diffing tasks available in the make-options.json.
This is not a new task. The task has been available for a while and usage is really low
The usage count was around 25 the last 30 days and now no usage is showing.
The reason why it wasn't already in make-options.json is something I don't have information on.
I will try to check the history of the file to see the changes made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#19445
This is the PR where changes seem related to this task
Not sure if the process was different then since it is specifically added to the Node 20 section and commit history is huge I didn't check till end. From what I see it was missing from first
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Context
The Courtesy Push pipeline is not picking up PyPIPublisherV0 Task as part of change list
The task was missing from the make-options.json which was used when pipeline calls filter-task.js
Task Name
NA - Not a task change
Description
Added PyPIPublisherV0 task to make-options.json to allow courtesy push pipeline to pickup the task
Risk Assessment (Low / Medium / High)
Low
Change Behind Feature Flag (Yes / No)
No
Tech Design / Approach
NA - No changes made
Documentation Changes Required (Yes/No)
NA - No changes made to functionality
Unit Tests Added or Updated (Yes / No)
NA - No changes made to functionality
Additional Testing Performed
NA - No changes made to functionality
Logging Added/Updated (Yes/No)
NA - No changes made to functionality
Telemetry Added/Updated (Yes/No)
NA - No changes made to functionality
Rollback Scenario and Process (Yes/No)
Revert PR to rollback
Dependency Impact Assessed and Regression Tested (Yes/No)
NA - No changes made to functionality
Checklist