[WIP] C# 14: Support extension blocks.
#21220
Draft
+766
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce support for
extensiontypes (blocks). The feature is explained in detail here.The feature generalises extensions to operators and properties.
Here is a small example of an declaration and how it can be invoked.
It turns out that Roslyn generates a static method corresponding to the extension method. To avoid extracting multiple methods with identical bodies (which would further complicate the QL implementation) we
IsValid()method, which has the qualified nameMyExtensions.extension(string).IsValid.stoIsValid()corresponding to the receiver parameters. This needs to be synthesised as we can't re-use the parameter from the extension declaration.MyExtensions.IsValidwithMyExtensions.extensions(string).IsValid.