Make digest auth support conditional (issue #232) #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When libmicrohttpd is built with --disable-dauth, the digest auth functions (MHD_digest_auth_get_username, MHD_digest_auth_check, MHD_queue_auth_fail_response) are not available, causing linker errors. This change detects digest auth availability at configure time and conditionally compiles the digest auth code, following the existing pattern used for GnuTLS support. Changes: - Add AC_CHECK_LIB detection for MHD_queue_auth_fail_response - Add HAVE_DAUTH preprocessor flag when digest auth is available - Wrap digest auth code in #ifdef HAVE_DAUTH guards - Show digest auth status in configure summary
Build the digest_authentication example only when HAVE_DAUTH is defined, consistent with the conditional digest auth support added in the library.
When libmicrohttpd is built with --disable-dauth, passing MHD_OPTION_NONCE_NC_SIZE or MHD_OPTION_DIGEST_AUTH_RANDOM to MHD_create_daemon() causes daemon creation to fail. This fixes the ws_start_stop test failure in the no-dauth CI build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #232: Linking libhttpserver fails when libmicrohttpd has digest auth disabled.
When libmicrohttpd is built with
--disable-dauth, the digest auth functions (MHD_digest_auth_get_username,MHD_digest_auth_check,MHD_queue_auth_fail_response) are not available, causing linker errors.This PR detects digest auth availability at configure time and conditionally compiles the digest auth code, following the existing pattern used for GnuTLS support.
Changes
AC_CHECK_LIBdetection forMHD_queue_auth_fail_responseinconfigure.acHAVE_DAUTHpreprocessor flag when digest auth is available#ifdef HAVE_DAUTHguards:src/http_request.cpp-check_digest_auth()andget_digested_user()src/httpserver/http_request.hpp- method declarations and cache membersrc/digest_auth_fail_response.cpp- entire implementationsrc/httpserver/digest_auth_fail_response.hpp- class definitionsrc/httpserver.hpp- conditional includetest/integ/authentication.cpp- digest auth testsTest plan
Digest Auth: yesno-dauthjob builds libmicrohttpd with--disable-dauthand verifies libhttpserver builds and tests pass