Fix regex URL exact match bug (issue #308) #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLs that exactly match a registered regex pattern string were incorrectly
dispatching to that resource instead of returning 404. For example,
registering `/foo/{v|[a-z]}/bar` and then requesting the literal URL
`/foo/{v|[a-z]}/bar` returned 200 instead of 404.
The root cause was that URLs with regex patterns were being added to
`registered_resources_str` (fast string lookup map). When a request
matched the literal pattern text, it bypassed regex validation.
Fix: Only add URLs without regex patterns to the fast string lookup map
by checking `idx.get_url_pars().empty()` before insertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
idx.get_url_pars().empty()before insertionbasic.cppFixes #308
Test plan
regex_url_exact_matchtest passes with expected 404 responsemake check)