Fix deferred_response content parameter not being used (issue #331) #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deferred_response constructor accepts a content parameter that was documented to send initial content before callback data, but was never actually used. This fix stores the content and sends it first before calling the user's callback. Changes: - Store content in initial_content member instead of passing to base class - Track content_offset for proper chunking of large content - Send initial content bytes before invoking user's cycle_callback - Add test for backward compatibility with empty content parameter
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
deferred_responseconstructor'scontentparameter which was documented to send initial content before callback data, but was never actually usedChanges
initial_contentmember instead of passing to base classstring_responsecontent_offsetfor proper chunking when content exceeds buffer sizecycle_callbackTest plan
make check)