Fix POST args with empty values not being parsed (issue #268) #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Destroy post processor before invoking the callback to ensure pending POST body keys with empty values are properly finalized. Without this, POST data like "arg1=val1&arg2=" would fail to include arg2. The fix moves MHD_destroy_post_processor call to finalize_answer() before the resource callback is invoked, rather than waiting for the modded_request destructor. Added test cases verifying: - arg1=val1&arg2= correctly parses both args - arg1= correctly parses as empty string - arg1=&arg2= correctly parses both as empty strings This supersedes PR #269 with the requested code style changes.
rand_r is POSIX-specific and not available on Windows. Since this is just a stress test where thread-safe randomness isn't critical, use the portable rand() function instead.
etr
force-pushed
the
fix-post-empty-arg-value
branch
from
2e9a4fb to
3733f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #268 - POST body keys without values at the end are not processed when using
application/x-www-form-urlencodedcontent type.This PR supersedes #269 with the requested changes:
nullptrinstead ofNULL(style fix)The Problem
When POST data ends with a key that has an empty value (e.g.,
arg1=val1&arg2=), the final key-value pair was not being processed. This happened becauseMHD_destroy_post_processorwas only called in the destructor, after the request handler had already executed.The Fix
Move the
MHD_destroy_post_processorcall tofinalize_answer()before the resource callback is invoked. This ensures any pending POST data is finalized before the handler accesses the arguments.Test Plan
empty_arg_value_at_endwith three cases:arg1=val1&arg2=→ correctly parses both argsarg1=→ correctly parses as empty stringarg1=&arg2=→ correctly parses both as empty strings