Re-enable MSan build in GitHub Actions CI #349
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the old commented-out MSan configuration (ubuntu-18.04 with clang-6.0) with a modern configuration using ubuntu-latest and clang-18, matching the other sanitizer builds (asan, lsan, tsan, ubsan). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Owner
Author
|
MSAN requires all libraries (even dependencies) to be MSAN compatible; way too expensive to do this as part of CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
The old MSan configuration was disabled because:
The new configuration uses:
os: ubuntu-latestcompiler: clang-18Note
MSan requires all linked code to be instrumented. If false positives occur from uninstrumented external libraries (libmicrohttpd, libgnutls, libcurl), consider using
MSAN_OPTIONS=halt_on_error=0or sanitizer ignorelists.🤖 Generated with Claude Code