Remove unused fNullOk parameter from GetMethodDescForComInterfaceMethod

[Copilot]

Description

The fNullOk parameter on MethodTable::GetMethodDescForComInterfaceMethod was always passed as false at its single call site. Analysis confirmed the function never returns NULL in practice.

Changes

• Removed bool fNullOk parameter from function signature and call site
• Fixed POSTCONDITION to disallow NULL return (removed NULL_OK flag)
• Replaced conditional NULL return path with assertion
  • The FindDynamicallyAddedInterface check now uses _ASSERTE() since it has no side effects and must always be true when reached

Before:

MethodDesc *GetMethodDescForComInterfaceMethod(MethodDesc *pItfMD, bool fNullOk)
{
    // ...
    else if (FindDynamicallyAddedInterface(pItfMT))
        RETURN(pItfMD);
    else
        RETURN(NULL);  // Never actually reached
}

After:

MethodDesc *GetMethodDescForComInterfaceMethod(MethodDesc *pItfMD)
{
    // ...
    _ASSERTE(FindDynamicallyAddedInterface(pItfMT));
    RETURN(pItfMD);  // Always returns valid MethodDesc
}

Microsoft Reviewers

Open in CodeFlow

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.