fix: stop scanning huggingface cache for e2e #4111
Open
+32
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmahabirbu
requested review from
a team,
benoitf and
jeffmaury
as code owners
jeffmaury
requested changes
Jan 23, 2026
Collaborator
jeffmaury
left a comment
jeffmaury
left a comment
There was a problem hiding this comment.
This does not fix correctly the issue as we have Huggingface models in the catalog.
This error is spawned when the Hub cache folder does not exist
Signed-off-by: Brian <bmahabir@bu.edu>
bmahabirbu
force-pushed
the
huggingface-cache-fix
branch
from
460e885 to
dd9e883
Compare
Contributor
Author
|
updated |
jeffmaury
reviewed
Jan 26, 2026
| // Check if cache directory exists before scanning | ||
| try { | ||
| const cachePath = getHFHubCachePath(); | ||
| await fs.access(cachePath); |
Collaborator
There was a problem hiding this comment.
praise: It was once stated that using existsSync should be preferred to async access as the cost of throwing exception could be greater.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pr fixes the error
during e2e
Screenshot / video of UI
What issues does this PR fix or reference?
How to test this PR?