fix: correctly resolve model folder paths in URLModelHandler #4110
+51
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian <bmahabir@bu.edu>
bmahabirbu
requested review from
a team,
benoitf and
jeffmaury
as code owners
Contributor
Author
|
The issue was that sometimes parentdir could be undefined, depending on the testing environment and the node version, which caused the error to be hidden sometimes this pr should get in then backported along with node 24 upgrade |
jeffmaury
reviewed
Jan 23, 2026
Collaborator
jeffmaury
left a comment
jeffmaury
left a comment
There was a problem hiding this comment.
Seems useless to me as 1.9.x is working for both Node 22 (Podman Desktop 1.24.x) and Node 24 (Podman Desktop 1.25.x)
Contributor
Author
|
It's still a bug in main it can happen depending on the node version and other factors like testing environment setup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Screenshot / video of UI
What issues does this PR fix or reference?
How to test this PR?