GH-49076: [CI] Update vcpkg baseline to newer version #49062
Conversation
raulcd
changed the title
raulcd
force-pushed
the
update-vcpkg-baseline
branch
from
ca3fc65 to
8c54b77
Compare
raulcd
force-pushed
the
update-vcpkg-baseline
branch
from
40c16b8 to
10803ea
Compare
| "name": "gtest", | ||
| "features": [ | ||
| "cxx17" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
This isn't necessary anymore since:
microsoft/vcpkg@b00ff11
There was a problem hiding this comment.
Actually should we add cxx20?
There was a problem hiding this comment.
no, this was removed. There's no additional features on vcpkg anymore. You can see that on the commit above. This is how the current port file looks (no features):
https://github.com/microsoft/vcpkg/blob/master/ports/gtest/vcpkg.json
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
raulcd
changed the title
|
|
|
Should we merge this or integrate it in #48765 ? |
I am fine with both. I was just putting it into a mergeable state but tbh the change is quite minor so I am happy if it gets integrated with your PR. |
raulcd
changed the title
github-actions
bot
added
awaiting changes
| if(utf8proc_FOUND) | ||
| add_library(utf8proc::utf8proc ALIAS utf8proc) | ||
| if(NOT TARGET utf8proc::utf8proc) | ||
| add_library(utf8proc::utf8proc ALIAS utf8proc) | ||
| endif() | ||
| return() | ||
| endif() |
There was a problem hiding this comment.
Recent vcpkg's utf8proc CMake package provides utf8proc::utf8proc CMake target, right?
If so, we can remove this if block entirely. We don't need to support old vcpkg.
There was a problem hiding this comment.
I am trying dropping the if block entirely on the last commit. Will merge if CI is successful. Thanks @kou
There was a problem hiding this comment.
ok, I got confused but I think I understand what you meant @kou !
github-actions
bot
added
awaiting merge
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting changes
3 participants
Rationale for this change
The current version of vcpkg used is a from April 2025
What changes are included in this PR?
Update baseline to newer version.
Are these changes tested?
Yes on CI. I've validated for example that xsimd 14 will be pulled.
Are there any user-facing changes?
No