-
Notifications
You must be signed in to change notification settings - Fork 46
[FTF-491] Add a nested table component #3130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 🧪 Unit Test Generation v2 is now available!We have significantly improved our unit test generation capabilities. To enable: Add this to your reviews:
finishing_touches:
unit_tests:
enabled: trueTry it out by using the Have feedback? Share your thoughts on our Discord thread! Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
8ff275f to
e0822dc
Compare
e0822dc to
bb2a54b
Compare
GregHolmes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this!
aralovelace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @m-hulbert this is great just a few small feedback
aralovelace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good ! Nicely done!
de8bf0c to
fd06671
Compare
Description
This PR adds a new nested table component described here: FTF-491.
It essentially allows for tables listing properties to be nested within one another when they reference a custom type, or enum.
This PR has several parts:
<Table>tags with various variables controlling this. Usingidensures the table can be referenced in another table cell, withhiddenensuring it isn't rendered standalone in the output.hiddenproperty is removed from markdown when rendering pages available as raw/copied MD to ensure LLMs do not ignore the content.Checklist