feat: The site-context getLabel has been made multilingual #20951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Language and Currency label values used in
site-context-selector.componentare fixed values withinsite-context-component.service. I've changed this to be compatible with multi-language structures.The Language and Currency label values used in
site-context-selector.componentare constant values withinsite-context-component.service. I've changed this to be compatible with multi-language structures.Now, instead of reading the label value from a constant variable, it reads it from the
languageandcurrencyparameters incommon.json. Also, thegetLabelfunction used to returnObservable<any>; I've changed this toObservable<string>for type safety.