Skip to content

Conversation

@GDYendell
Copy link
Contributor

@GDYendell GDYendell commented Jan 30, 2026

This fix handles a case for the odin meta writer where it returns None for a String datatype. The problem was that it was correctly using the validated value to set the readback, but the original value to set the setpoint.

This also fixes a potential issue that initially thought was the problem where String.length is None and used to truncate strings in the EPICS CA transport and improves some trace messages that made this issue much easier to figure out. Using repr(value) in log messages means strings appear as 'None' instead of None.

It was already doing the right thing in the other case here.

@GDYendell GDYendell requested a review from shihab-dls January 30, 2026 11:19
@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.79%. Comparing base (3fe7b0c) to head (9369eba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   90.79%   90.79%           
=======================================
  Files          70       70           
  Lines        2542     2543    +1     
=======================================
+ Hits         2308     2309    +1     
  Misses        234      234           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GDYendell GDYendell force-pushed the setpoint-set-validation branch from 89e8200 to 265f07c Compare January 30, 2026 11:33
Improve trace logging of attribute set
Fix potential NoneType error
@GDYendell GDYendell force-pushed the setpoint-set-validation branch from 265f07c to 9369eba Compare January 30, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants