Call sync setpoint callbacks with validated value #315
+38
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix handles a case for the odin meta writer where it returns None for a String datatype. The problem was that it was correctly using the validated value to set the readback, but the original value to set the setpoint.
This also fixes a potential issue that initially thought was the problem where String.length is None and used to truncate strings in the EPICS CA transport and improves some trace messages that made this issue much easier to figure out. Using
repr(value)in log messages means strings appear as'None'instead ofNone.It was already doing the right thing in the other case here.