Fix # deletion 2766 #3002
Open
Fix # deletion 2766 #3002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces several test cases to verify the behavior of deleting `#()` forms and related constructs in the paredit sandbox. These tests ensure that backspace and delete operations function as expected, enhancing the reliability of the paredit functionality.
This update introduces tests for the deletion of hash characters (#) in various contexts involving reader macros. The tests ensure that hash characters are correctly deleted or preserved based on their surrounding syntax, improving the robustness of the paredit functionality.
Improve the backspace function to correctly manage deletion behavior when interacting with reader macro tokens. This includes special cases for empty reader macros and invalid prefixes, ensuring a smoother editing experience in the paredit sandbox. Fixes # is not deleted in specific case Fixes BetterThanTomorrow#2766
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Detect if the cursor is inside the '#' prefix of a reader macro token before the opening delimiter. This improves the backspace behavior when editing reader macros, ensuring a smoother user experience.
Updated the backspace function to simplify token type checks by replacing the Set with an array for JUMP_TOKEN_TYPES. This change improves readability and maintains functionality when handling reader macro tokens.
Introduce a constant for open delimiters regex to improve code readability and maintainability. Update backspace function to use this constant for checking token boundaries within reader macros.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve backspace and deleteForward functions for reader macro hash deletion
What has changed?
Enhanced backspace function in
src/cursor-doc/paredit.ts: Added comprehensive logic to handle deletion behavior when interacting with reader macro tokens (#(,#{), distinguishing between empty and non-empty forms, and properly managing cursor positioning.Enhanced deleteForward function in
src/cursor-doc/paredit.ts: Added detection for invalid reader prefixes (junk#tokens) and reader macro start positions, allowing proper deletion of#characters in appropriate contexts.Added comprehensive test suite: Implemented 12 new tests covering all hash character deletion scenarios for both backspace and delete-forward operations, ensuring robust behavior across different reader macro contexts.
The implementation correctly handles:
#(),#{}) - jumps over#instead of deleting#(prn "hello"),#{:foo :bar}) - allows#deletion#[...], junk#tokens) - allows#deletionFixes #2766
My Calva PR Checklist
I have:
devbranch. (Or have specific reasons to target some other branch.)published. (Sorry for the nagging.)[Unreleased]entry inCHANGELOG.md, linking the issue(s) that the PR is addressing.npm run prettier-format)npm run eslintbefore creating your PR, or runnpm run eslint-watchto eslint as you go).